(CAT-1417) Nested require support for authz_core mod #2460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
4 times, most recently
from
39bf331 to
4c2f279
Compare
bastelfreak
reviewed
Sep 15, 2023
bastelfreak
reviewed
Sep 15, 2023
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
2 times, most recently
from
1b4316a to
504c409
Compare
Contributor
Author
|
Addressed with all changes and now ready for review. |
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
from
504c409 to
d0f9034
Compare
smortex
reviewed
Sep 18, 2023
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
That looks great, I added in-line notes for a few rather minor points.
I am also wondering if we can add an argument to the recursive function so that the generated code has indentation?
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
6 times, most recently
from
ded5fc9 to
37d7863
Compare
Contributor
Author
Have fixed the indentation. |
david22swan
previously approved these changes
Sep 18, 2023
smortex
reviewed
Sep 18, 2023
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
A few style comments and LGTM!
Ramesh7
dismissed stale reviews from david22swan and gavindidrichsen
via
0e9dd68
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
from
37d7863 to
0e9dd68
Compare
smortex
previously approved these changes
Sep 18, 2023
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
LGTM, just the documentation missing makes me skeptical.
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
from
0e9dd68 to
c179f67
Compare
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
2 times, most recently
from
2686955 to
b9c9405
Compare
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
from
b9c9405 to
0a64748
Compare
Co-authored-by: Romain Tartière <[email protected]>
Ramesh7
force-pushed
the
CAT-1417-nested-require-for-authz-mod
branch
from
0a64748 to
c9cc80d
Compare
smortex
approved these changes
Sep 21, 2023
Comment on lines
-7579
to
-7580
| lint:ignore:parameter_documentation | ||
| lint:endignore |
Collaborator
There was a problem hiding this comment.
Removing 💩 from the doc. Awesome 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
#2315
Related Issues (if any)
#2315
Checklist
puppet apply)