CAT-1347 erb to epp conversion #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinesh-gujar
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
ekohl
reviewed
Sep 14, 2023
ekohl
reviewed
Sep 14, 2023
smortex
reviewed
Sep 14, 2023
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
from
3c83e15 to
22eca98
Compare
Contributor
|
can you please update your branch with main? |
Author
yes just waiting for review for my changes once approved will do that and will also do the rebase |
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
Ramesh7
reviewed
Sep 21, 2023
ekohl
reviewed
Sep 21, 2023
ekohl
requested changes
Sep 21, 2023
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
from
2b060c3 to
6dcf415
Compare
ekohl
reviewed
Sep 21, 2023
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Minor notes. I'd also like to see data types in the EPP templates, but wouldn't block on that.
ekohl
reviewed
Sep 21, 2023
ekohl
reviewed
Sep 21, 2023
ekohl
previously requested changes
Sep 21, 2023
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
5 times, most recently
from
3ee4bf7 to
b259171
Compare
Author
|
@ekohl resolved the comments. |
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
3 times, most recently
from
6352b60 to
d95e93e
Compare
Author
|
@ekohl please review |
ekohl
reviewed
Sep 22, 2023
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
3 times, most recently
from
55dd42f to
1935b2b
Compare
dinesh-gujar
force-pushed
the
CAT-1347-erb-to-epp-conversion-vhost-files
branch
from
1935b2b to
31a137b
Compare
praj1001
approved these changes
Sep 29, 2023
Contributor
|
LGTM |
praj1001
approved these changes
Sep 29, 2023
Author
|
1 requested change is done but still showing up in git hub so dismissing review |
dinesh-gujar
dismissed
ekohl’s stale review
addressed and resolved the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converting ERB files to EPP for performance upgrade.