Skip to content

Conversation

@Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Aug 29, 2023

Summary

Recently rolled-out puppet-lint gem checking title as well for unsafe interpolation which seems to be a issue with feature so, downgrading the gem version to avoid the unsafe interpolation issue for title.
Have reported the same to Team.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

  • N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 requested review from a team, bastelfreak, ekohl and smortex as code owners August 29, 2023 13:24
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 on this. In puppetlabs/puppet-lint#147 it's proposed to drop the check instead, which would avoid requiring to do updates everywhere.

@Ramesh7
Copy link
Contributor Author

Ramesh7 commented Aug 29, 2023

👎 on this. In puppetlabs/puppet-lint#147 it's proposed to drop the check instead, which would avoid requiring to do updates everywhere.

Thanks @ekohl, just now noticed that we are reverting the unsafe check. Closing the same.

@Ramesh7 Ramesh7 closed this Aug 29, 2023
@Ramesh7 Ramesh7 deleted the CAT-1351 branch August 30, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants