Skip to content

(CAT-2052) Pass target container URI instead of container SHA ID to add_feature_to_node() method #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

(CAT-2052) Pass target container URI instead of container SHA ID to add_feature_to_node() method #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/puppet_litmus/rake_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
Rake::Task['spec_prep'].invoke

results = install_agent(args[:collection], targets, inventory_hash)
target_index = 0

Check warning on line 131 in lib/puppet_litmus/rake_tasks.rb

View check run for this annotation

Codecov / codecov/patch

lib/puppet_litmus/rake_tasks.rb#L131 

Added line #L131 was not covered by tests
results.each do |result|
command_to_run = "bolt task run puppet_agent::install --targets #{result['target']} --inventoryfile spec/fixtures/litmus_inventory.yaml --modulepath #{DEFAULT_CONFIG_DATA['modulepath']}"
raise "Failed on #{result['target']}\n#{result}\ntry running '#{command_to_run}'" if result['status'] != 'success'
Expand Down Expand Up @@ -157,7 +158,8 @@
end

# add puppet-agent feature to successful nodes
inventory_hash = add_feature_to_node(inventory_hash, 'puppet-agent', result['target'])
inventory_hash = add_feature_to_node(inventory_hash, 'puppet-agent', targets[target_index])
target_index += 1

Check warning on line 162 in lib/puppet_litmus/rake_tasks.rb

View check run for this annotation

Codecov / codecov/patch

lib/puppet_litmus/rake_tasks.rb#L161-L162 

Added lines #L161 - L162 were not covered by tests
end

# update the inventory with the puppet-agent feature set per node
Expand Down