Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.x] Add files to include in tarball #9457

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

github-actions[bot]
Copy link

Description

Backport of #9454 to 7.x.

Previously, Puppet relied on the in-house Packaging library to build all
artifacts related to Puppet. Puppet moved away from using Packaging to
build gems in 867ce9c, which also removed the files key used to build
tarballs.

This commit re-adds the files key (as a list instead of a string, as
recommended by Packaging) to enable the packaging:tar Rake task, which
builds source tarballs of Puppet.

(cherry picked from commit 314a107)
@github-actions github-actions bot requested a review from a team as a code owner August 27, 2024 16:01
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@mhashizume mhashizume closed this Aug 27, 2024
@mhashizume mhashizume reopened this Aug 27, 2024
@mhashizume
Copy link
Contributor

Tests will fail on this until #9456 is merged

@mhashizume mhashizume closed this Aug 27, 2024
@mhashizume mhashizume reopened this Aug 27, 2024
@mhashizume mhashizume merged commit 56631ee into 7.x Aug 27, 2024
14 of 23 checks passed
@mhashizume mhashizume deleted the backport-9454-to-7.x branch August 27, 2024 17:29
@mhashizume mhashizume added the maintenance Maintenance chores are excluded from changelogs label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants