(bug) - Honour custom insync in noop mode #9443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a custom insync message was not honoured when applying a manifest in noop mode. This was later tracked down the the `noop` method found in the resource harness class. I've updated the method to match that of the `sync` method below, ensuring that the functionality of the custom isync provider feature is not any different whether running puppet in noop or no-noop mode.
|
jenkins please test this |
joshcooper
approved these changes
Aug 6, 2024
|
Thanks for your patience @jordanbreen28! This will be release in the next 8.9.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, a custom insync message was not honoured when applying a manifest in noop mode. This was later tracked down to the offending noop method found in the resource harness class, which did not call the change_to_s method to retrieve the custom insync message.
I've updated the method to match that of the sync method below, ensuring that the functionality of the custom isync provider feature is not any different whether running puppet in noop or no-noop mode.
Can see the two methods here
Additional Context
Have opted out of adding a space between (noop) and audit_message to match the three other implementations of this in the sync and noop methods.