Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated DESTDIR and unused things from install.rb #9425

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Remove deprecated DESTDIR and unused things from install.rb #9425

merged 3 commits into from
Jul 25, 2024

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jul 24, 2024

I was trying to figure out how to do the install parts for #8636 and trying to make sense of the install script. In doing so I found some things that have been unused for ages. Things get easier to understand if there's less stuff, so this helps a bit.

@ekohl ekohl requested a review from a team as a code owner July 24, 2024 19:53
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

joshcooper
joshcooper reviewed Jul 25, 2024
View reviewed changes
install.rb Show resolved Hide resolved
@ekohl ekohl changed the title Remove deprecated DESTDIR and unused things from intall.rb Remove deprecated DESTDIR and unused things from install.rb Jul 25, 2024
ekohl added 3 commits July 26, 2024 00:40
@ekohl
Remove rdoc and ri options from install.rb
af46b4a 
Since 584652c the build_rdoc and
build_ri methods have been commented out meaning these options never did
anything.
@ekohl
Remove deprecated DESTDIR from install.rb
95024d6 
In 469c5fe this was deprecated, giving
people 16 years to migrate.
@ekohl
Remove unused InstallOptions.lib_dir
7d07ea5 
This has been unused since 5416017.
@ekohl ekohl force-pushed the remove-unused-install-stuff branch from ec365b9 to 7d07ea5 Compare July 25, 2024 22:41
@joshcooper
Copy link
Contributor

jenkins please test this

@joshcooper
Copy link
Contributor

just waiting on tests

@joshcooper joshcooper merged commit f3d12c2 into puppetlabs:main Jul 25, 2024
15 checks passed
@joshcooper joshcooper added the bug Something isn't working label Jul 25, 2024
@ekohl ekohl deleted the remove-unused-install-stuff branch July 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @puppetlabs-jenkins @joshcooper @bastelfreak