Check for nil before closing Uniquefile #9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
force-pushed
the
uniquefile_9385
branch
3 times, most recently
from
319bef5 to
a47b312
Compare
joshcooper
force-pushed
the
uniquefile_9385
branch
2 times, most recently
from
d879bf8 to
db83e48
Compare
On Windows, we by default assign stdout for the child process to a file:
stdout = Puppet::FileSystem::Uniquefile.new('puppet')
However, if TMPDIR, TEMP or TMP env vars refer to a non-existent directory, then
`Uniquefile.new` will raise, leaving `stdout` set to nil, so the later call to
`stdout.close` raised NoMethodError.
So check for nil before closing. We don't have this issue on posix, because
it uses an IO pipe instead of Uniquefile.
Fixes puppetlabs#9385
joshcooper
force-pushed
the
uniquefile_9385
branch
from
db83e48 to
7296cce
Compare
mhashizume
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, if squelch was false and Uniquefile.new raised, then we attempted to
close a nil stdout. This scenario can occur if TEMP or similar environment
variable is defined but refers to a non-existent directory.
So check for nil before closing. We don't have this issue on posix, because
it uses an IO pipe instead of Uniquefile.
Fixes #9385