-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Add xbps used by voidlinux as a package provider #8976
Conversation
Can one of the admins verify this patch? |
0cddefc
to
ed1348e
Compare
@joshcooper @tvpartytonight (just pinging). Rebased on tip of main branch removing conflicts, can someone please review. |
Hi @Animeshz thanks for your pull request! I had a few minor comments, but generally looked great. |
I got those addressed (and tested basic functionality on local machine), let me know if anything else has to be done. |
Sorry I didn't performed lint checks. I've addressed those nuances now. And tests should now pass. Please have a look 😄 |
closing and reopening to trigger checks |
@Animeshz can you fix the rubocop checks by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Animeshz this will be released in the next puppet 8 version
I wanted to use puppet on void-linux, so this PR adds the package provider for xbps.
Let me know if any changes has to be made :)