Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) ci: add GitHub token permissions for workflows #8924

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

varunsh-coder
Copy link
Contributor

This PR adds minimum token permissions for the GITHUB_TOKEN using https://github.com/step-security/secure-workflows.

GitHub recommends defining minimum GITHUB_TOKEN permissions for securing GitHub Actions workflows

This project is part of the top 100 critical projects as per OpenSSF (https://github.com/ossf/wg-securing-critical-projects), so fixing the token permissions to improve security.

Signed-off-by: Varun Sharma [email protected]

@varunsh-coder varunsh-coder requested a review from a team as a code owner July 11, 2022 15:15
@varunsh-coder varunsh-coder requested a review from a team July 11, 2022 15:15
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022

CLA assistant check
All committers have signed the CLA.

@LivingInSyn
Copy link

@puppetlabs/security is good with the change 👍

@joshcooper
Copy link
Contributor

@varunsh-coder thank you for your contribution! Could you prefix your git commit summary with (maint) ... as
described here and force push to your feature branch?

@varunsh-coder
Copy link
Contributor Author

@varunsh-coder thank you for your contribution! Could you prefix your git commit summary with (maint) ... as
described here and force push to your feature branch?

Done!

@joshcooper joshcooper changed the title ci: add GitHub token permissions for workflows (maint) ci: add GitHub token permissions for workflows Aug 9, 2022
@joshcooper joshcooper merged commit ca8889d into puppetlabs:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants