(CAT-1669) - Fix hashrocket allignment on completion item select #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, when selecting a param/prop from the dropdown completion list in puppet-vscode, the hash rocket would not be formatted inline with the rest of the document.
This PR implements a middleware to the language client, and adds a vscode API item command which allows us to execute a vscode command after the selection of the param/prop from the dropdown list. So when an param/prop is selected, we send a callback event to the language server to format the document.
This is only possible on the vscode side thanks to the vscode API, unfortunately there is no suitable events to implement this into the langauge server.
Also not possible as:
Related Issues (if any)
Fixes #884
Checklist