List puppet as runtime dependency #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppe is a runtime dependency: ``` $ git grep "require 'puppet/" lib/puppet-strings/yard/parsers/puppet/parser.rb:require 'puppet/pops' lib/puppet-strings/yard/parsers/puppet/statement.rb:require 'puppet/pops' lib/puppet-strings/yard/util.rb:require 'puppet/util' lib/puppet/application/strings.rb:require 'puppet/application/face_base' lib/puppet/face/strings.rb:require 'puppet/face' lib/puppet/feature/rgen.rb:require 'puppet/util/feature' lib/puppet/feature/yard.rb:require 'puppet/util/feature' spec/spec_helper.rb:require 'puppet/version' ```
bastelfreak
added a commit
to bastelfreak/voxpupuli-release
that referenced
this pull request
Dec 22, 2024
`puppet` is a runtime dependency for puppet-strings: puppetlabs/puppet-strings#404 Adding puppet as runtime dependency for voxpupuli-release is our hotfix for the broken puppet-strings.
|
I assume this wasn't discovered in the past because the Gemfile pulls in puppet as well. That should probably be fixed as well. |
|
I've let the DevX channel now but I suspect were in full holiday swing so I will remind when people are back on line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppe is a runtime dependency:
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist