(maint) Address rubocop failures in unit tests #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the nightlies were failing due to a change in Rubocop. This PR addresses the failures.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 70.91% 70.91%
=======================================
Files 78 78
Lines 2486 2486
=======================================
Hits 1763 1763
Misses 723 723 ☔ View full report in Codecov by Sentry. |
jordanbreen28
approved these changes
Apr 5, 2024
bastelfreak
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Looks good to me. But should we also pin rubocop so we don't pull in unwanted updates that break CI again? Vox pupuli also offers https://github.com/voxpupuli/voxpupuli-rubocop which provides a tested rubocop version + config. Vox pupuli uses that in all their gems to manage rubocop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the nightlies were failing due to a change in Rubocop. This PR addresses the failures.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist