Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FIXUP) Check for nil before injecting provider param into Types #285

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jul 7, 2021

cc @nkanderson

See https://forge.puppet.com/modules/enterprisemodules/ora_install/5.12.3 for an example of a module that would trigger an error before.

Error triggered was:

$ bx puppet strings generate --format json /Users/jesse/tmp/enterprisemodules-ora_install-5.12.3/ --trace
Error: undefined method `any?' for nil:NilClass
/Users/jesse/src/puppet-strings/lib/puppet-strings/yard/code_objects/type.rb:155:in `parameters'
/Users/jesse/src/puppet-strings/lib/puppet-strings/yard/code_objects/type.rb:187:in `to_hash'
/Users/jesse/src/puppet-strings/lib/puppet-strings/json.rb:16:in `map!'
/Users/jesse/src/puppet-strings/lib/puppet-strings/json.rb:16:in `render'
/Users/jesse/src/puppet-strings/lib/puppet-strings.rb:78:in `render_json'
/Users/jesse/src/puppet-strings/lib/puppet-strings.rb:59:in `generate'
...
Error: Try 'puppet help strings generate' for usage

@scotje scotje requested a review from a team as a code owner July 7, 2021 23:29
@da-ar da-ar merged commit f4edde0 into puppetlabs:main Jul 19, 2021
@chelnak chelnak added the bugfix label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants