(PDOC-285) Fix data_type_handler for errors and numbers #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the data_type_handler would throw errors if the ruby datatype had errors in the puppet interface definition. This commit traps the Puppet Syntax Errors and throws a useful warning explaining where the error occured and allows yard to continue parsing. Previously numeric default values were not being detected correctly. This commit updates the Literal Evaluator to understand negative values and also adds tests for the different kinds of Puppet Literal Numbers.
glennsarti
force-pushed
the
maint-fix-datatype
branch
from
fe0b896
to
47ebd87
Compare
glennsarti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the data_type_handler would throw errors if the ruby datatype had
errors in the puppet interface definition. This commit traps the Puppet Syntax
Errors and throws a useful warning explaining where the error occured and allows
yard to continue parsing.
Previously numeric default values were not being detected correctly. This
commit updates the Literal Evaluator to understand negative values and also adds
tests for the different kinds of Puppet Literal Numbers.