(PDOC-272) Add required features attribute #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris-bosland
changed the title
kris-bosland
changed the title
|
Edited title - closing and reopening to get JIRA to parse it. |
scotje
approved these changes
Mar 22, 2019
| @@ -99,6 +107,8 @@ def set_values(node, object) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
can delete this extra whitespace
There was a problem hiding this comment.
Hey @scotje, I think I was having some problem with my commits, but I think it is resolved now. Extra lines are removed!
With this change, the required_features argument to newparam and newproperty is parsed. This data is added to YARD objects and the to_hash output. It is also added to results for describe, json, and markdown rendering.
kris-bosland
force-pushed
the
pdoc-272-add-required-features-attribute
branch
from
7d5c2f2
to
b65018e
Compare
|
@scotje , I have cleaned up and done some rebasing - please re-review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the required_features argument to newparam and newproperty is parsed.
This data is added to YARD objects and the to_hash output. It is also added to results
for describe, json, and markdown rendering.