Correct rubocop warnings

Signed-off-by: Gavin Didrichsen <[email protected]>
puppetlabs · Jun 20, 2024 · 60fa51d · 60fa51d
1 parent 947d2c7
commit 60fa51d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/lib/puppet-strings/yard/code_objects/task.rb b/lib/puppet-strings/yard/code_objects/task.rb
@@ -44,14 +44,12 @@ def source
   end
 
   def parameters
-    parameters = []
-    statement.parameters.each do |name, props|
-      parameters.push({ name: name.to_s,
-                        tag_name: 'param',
-                        text: props['description'] || '',
-                        types: [props['type']] || '' })
+    statement.parameters.map do |name, props|
+      { name: name.to_s,
+        tag_name: 'param',
+        text: props['description'] || '',
+        types: [props['type']] || '' }
     end
-    parameters
   end
 
   # Converts the code object to a hash representation.

diff --git a/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb b/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb
@@ -107,9 +107,8 @@ def populate_provider_data(object)
         parameters.each do |kvps|
           next unless kvps.count >= 1
 
-          defaultfor = []
-          kvps.each do |kvp|
-            defaultfor << [node_as_string(kvp[0]) || kvp[0].source, node_as_string(kvp[1]) || kvp[1].source]
+          defaultfor = kvps.map do |kvp|
+            [node_as_string(kvp[0]) || kvp[0].source, node_as_string(kvp[1]) || kvp[1].source]
           end
           object.add_default(defaultfor)
         end