-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PA-4872) openssl 3 solaris 11 x86 #691
(PA-4872) openssl 3 solaris 11 x86 #691
Conversation
This needs rebasing due to merge conflicts. |
ah it looks like there's a merge commit in the feature branch. Could you instead rebase these commits onto upstream/master like
You'll get some conflicts which need to be resolved, then
The reason for going through this trouble is merge commits in pull requests make it difficult to understand git history. So the rebase workflow is preferred. |
4e30a3b
to
4ea52ef
Compare
Thanks for the help Josh, greatly appreciated. |
This PR continues Aria's work for getting Solaris 11 x86-64 building openssl 3. This uses OpenCSW's GCC to build openssl.
4ea52ef
to
c47a9e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If you haven't already, could you vanagon-generic-build these project & platform combinations:
❯ bx rake vanagon:component_diff -- -P agent-runtime-7.x -p all --from 46c127e --to HEAD | grep 'Platform name'
Platform name: solaris-11-i386
❯ bx rake vanagon:component_diff -- -P agent-runtime-main -p all --from 46c127e --to HEAD | grep 'Platform name' | grep -v solaris-10
Platform name: solaris-11-sparc
Platform name: solaris-11-i386
We can ignore solaris 10 on agent-runtime-main
Here is the solaris-11-i386 for agent-runtime-7.x: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/2118/BUILD_TARGET=solaris-11-i386,SLAVE_LABEL=k8s-worker/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running those. I'm not concerned about the solaris 11 sparc failures in agent-runtime-main
No description provided.