(CONT-670) Add legacy facts check #91
Merged
+603
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 27, 2023
This commit adds the required spec tests for the legacy facts check.
chelnak
force-pushed
the
CONT-670-add_legacy_facts_check
branch
from
179b889 to
b3d4e1c
Compare
bastelfreak
approved these changes
Feb 27, 2023
GSPatton
approved these changes
Feb 27, 2023
GSPatton
left a comment
GSPatton
left a comment
There was a problem hiding this comment.
looks good. Ran locally and works as expected
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the Legacy Facts check originally authored by @mmckinst.
Additional contributions to the check were made by @seanmil, @rodjek, @baurmatt, @bart2 and @joshcooper