(CONT-1027) Deprecate pe-version option #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
changed the title
chelnak
changed the title
chelnak
force-pushed
the
CONT-1027-deprecate_pe_version_option
branch
from
e815579
to
c8e78e1
Compare
The --pe-version flag has not been fully functional since PDK 2.7. This is because the metadata it used to derive versions became out dated and caused inconsistencies. Additionally we also remove a depependency on a third party service. This change marks the option deprecated and adds a warning to direct users towards the --puppet-version flag
This change removes or updates a number of tests that previously pointed to the pe-version option.
This change removes a number of references to the pe-version option in PDK's docs.
chelnak
force-pushed
the
CONT-1027-deprecate_pe_version_option
branch
from
c8e78e1
to
70fdc55
Compare
Ramesh7
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --pe-version flag has not been fully functional since PDK 2.7.
This is because the metadata it used to derive versions became outdated and caused inconsistencies.
Additionally we also remove a depependency on a third party service.
This change marks the option deprecated and adds a warning to direct users towards the --puppet-version flag.