Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ISS-1123) Verbose output w/ junit file #1246

Merged
merged 1 commit into from
May 30, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented May 4, 2023

Summary

This commit adds functionality to ensure pdk respects the verbose option when also utilizing format options for unit testing.

Detailed Changes

  • lib/pdk/tests/unit.rb
    • Adds conditional to run interactive_rake command when -v -f junit:report.xml is passed to pdk test unit command.
    • Note: Unless the first rake command contains failed events the tests will run twice; once for documentation output and again to export to specified file format(s).

@coreymbe coreymbe force-pushed the ISS-1123-format_with_verbose branch 2 times, most recently from f78ebc2 to 4d60b66 Compare May 8, 2023 18:46
@chelnak
Copy link
Contributor

chelnak commented May 9, 2023

This looks great, thank you!

Looks like there are a few CI failures to address before we can get it merged in.

Let me know if you need any help.

@chelnak chelnak self-assigned this May 9, 2023
@coreymbe coreymbe force-pushed the ISS-1123-format_with_verbose branch from 4d60b66 to 1922349 Compare May 26, 2023 18:11
@chelnak
Copy link
Contributor

chelnak commented May 27, 2023

Re kicked the failed test... this is a flakey one that we know about.

@coreymbe coreymbe force-pushed the ISS-1123-format_with_verbose branch from 1922349 to cfcec64 Compare May 30, 2023 16:36
@coreymbe coreymbe marked this pull request as ready for review May 30, 2023 16:36
@coreymbe coreymbe requested a review from a team as a code owner May 30, 2023 16:36
@chelnak chelnak merged commit de3089e into puppetlabs:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants