Allow cloud metadata to ignore proxy settings #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates method documentation into YARD formatting.
mhashizume
force-pushed
the
FACT-636/main/cloud-proxy-positional-arg
branch
3 times, most recently
from
278b2f7
to
2432c49
Compare
joshcooper
reviewed
Apr 12, 2024
Prior to this commit, if the http_proxy environment variable was set for Net::HTTP, cloud resolvers (ec2, GCE, Azure) would fail to resolve metadata. This commit adds a new positional argument to Facter::Util::Resolvers::Http.get_request and #put_request to allow those resolvers to disable proxy settings.
mhashizume
force-pushed
the
FACT-636/main/cloud-proxy-positional-arg
branch
from
2432c49
to
35963ca
Compare
joshcooper
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if the http_proxy environment variable was set for Net::HTTP, cloud resolvers (ec2, GCE, Azure) would fail to resolve metadata.
This commit adds a new positional argument to Facter::Util::Resolvers::Http.get_request and #put_request to allow those resolvers to disable proxy settings.