(FACT-3202) Add is_virtual and virtual support for crio #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lollipopman
force-pushed
the
crio-container-support
branch
2 times, most recently
from
e93f832
to
0cd5606
Compare
|
Would love a review if any of the codeowners have a moment? |
|
friendly bump for a review please |
|
@joshcooper any chance you would have time to take a gander? |
|
friendly bump for a review! |
|
Would love a review, any takers? |
|
would love a review! |
|
friendly bump! |
|
Hi @lollipopman thanks for the PR, could you update your PR so there's no conflicts? Thanks! |
lollipopman
force-pushed
the
crio-container-support
branch
from
0cd5606
to
bae8f48
Compare
|
Happy to, pushed, thanks for looking @AriaXLi |
lollipopman
force-pushed
the
crio-container-support
branch
3 times, most recently
from
21afec5
to
a6f1604
Compare
|
@AriaXLi tests are passing, do you think you could take a look? thanks! |
|
@AriaXLi any chance you could look at this again, before it bitrots? <3 |
joshcooper
reviewed
Jun 5, 2024
joshcooper
reviewed
Jun 5, 2024
joshcooper
reviewed
Jun 5, 2024
joshcooper
reviewed
Jun 5, 2024
joshcooper
reviewed
Jun 5, 2024
joshcooper
reviewed
Jun 5, 2024
Prior to this commit the safe_readlines wrapper did not support the sep argument as supported by readlines.
lollipopman
force-pushed
the
crio-container-support
branch
from
a6f1604
to
15e7f17
Compare
|
@joshcooper patch updated, ready for another review |
|
Thank you @lollipopman looks good, just running tests |
Prior to this change facter returned:
$ facter is_virtual
false
$ facter virtual
physical
After this change facter returns:
$ facter is_virtual
true
$ facter virtual
crio
This change separates out reading pid 1's environment from proc and
reading the cgroup information. It also adds explicit support for podman
and returns container_other when the container runtime is not explicitly
supported.
lollipopman
force-pushed
the
crio-container-support
branch
from
15e7f17
to
7bc38cc
Compare
|
Tests look good, anything else to do @joshcooper? |
joshcooper
approved these changes
Jun 7, 2024
|
Thank you @lollipopman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change facter returned:
After this change facter returns:
This change separates out reading pid 1's environment from proc and reading the cgroup information. It also adds a container_other type when the container runtime is not explicitly supported.