(FACT-3119) RFC2863 operational state for network interfaces

[jcpunk]

This adds RFC2863 operational state information for Linux.

I confess I'll need help with the tests....

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[joshcooper]

The code looks good to me, I think the one question is whether operational state is too linux specific: https://docs.kernel.org/networking/operstates.html? I think the answer is no, since there's an SNMP MIB defined in the linked RFC https://datatracker.ietf.org/doc/html/rfc2863#section-6 and it shows up in non-Linux hosts too:
https://learn.microsoft.com/en-us/dotnet/api/system.net.networkinformation.operationalstatus?view=net-7.0

[b4ldr]

changes look good to me but i don't have any rights :)

[joshcooper]

@jcpunk can you rebase on upstream and resolve the test failures? This seemed to resolve the linux ones, but there may be others:

diff --git a/spec/facter/resolvers/linux/networking_spec.rb b/spec/facter/resolvers/linux/networking_spec.rb
index 21d9e6b43..4e42783d4 100644
--- a/spec/facter/resolvers/linux/networking_spec.rb
+++ b/spec/facter/resolvers/linux/networking_spec.rb
@@ -21,6 +21,8 @@ describe Facter::Resolvers::Linux::Networking do
       allow(File).to receive(:exist?).with('/proc/net/if_inet6').and_return(true)
       allow(Facter::Util::FileHelper).to receive(:safe_read)
         .with('/proc/net/if_inet6', nil).and_return(load_fixture('proc_net_if_inet6').read)
+      allow(Facter::Util::FileHelper).to receive(:safe_read).with('/sys/class/net/lo/operstate', nil).and_return('unknown')
+      allow(Facter::Util::FileHelper).to receive(:safe_read).with('/sys/class/net/ens160/operstate', nil).and_return('up')
     end
 
     after do
@@ -68,6 +70,7 @@ describe Facter::Resolvers::Linux::Networking do
           netmask6: 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff',
           network: '127.0.0.0',
           network6: '::1',
+          operational_state: 'unknown',
           scope6: 'host'
         },
         'ens160' => {
@@ -88,6 +91,7 @@ describe Facter::Resolvers::Linux::Networking do
           netmask6: 'ffff:ffff:ffff:ffff::',
           network: '10.16.112.0',
           network6: 'fe80::',
+          operational_state: 'up',
           scope6: 'link'
         }
       }
@@ -158,6 +162,7 @@ describe Facter::Resolvers::Linux::Networking do
           netmask6: 'ffff:ffff:ffff:ffff::',
           network: '10.16.112.0',
           network6: 'fe80::',
+          operational_state: 'up',
           scope6: 'link'
         }
       end
@@ -207,7 +212,8 @@ describe Facter::Resolvers::Linux::Networking do
           mac: '00:50:56:9a:61:46',
           mtu: 1500,
           netmask: '255.255.240.0',
-          network: '10.16.112.0'
+          network: '10.16.112.0',
+          operational_state: 'up',
         }
 
         expect(networking_linux.resolve(:interfaces)['ens160']).to eq(expected)
@@ -297,8 +303,6 @@ describe Facter::Resolvers::Linux::Networking do
         allow(File).to receive(:exist?).with('/proc/net/if_inet6').and_return(true)
         allow(Facter::Util::FileHelper).to receive(:safe_read)
           .with('/proc/net/if_inet6', nil).and_return(load_fixture('proc_net_if_inet6').read)
-        allow(Facter::Util::FileHelper).to receive(:safe_read).with('/sys/class/net/lo/operstate').and_return('unknown')
-        allow(Facter::Util::FileHelper).to receive(:safe_read).with('/sys/class/net/ens160/operstate').and_return('up')
       end
 
       it 'returns all the interfaces' do

[jcpunk]

I've rebased, hopefully that helps.

[joshcooper]

@jcpunk Could you rebase?

[jcpunk]

Rebased

[joshcooper]

Ignore the rubocop error, I'll put up a PR to remove that check

[joshcooper]

Follow up PR #2607