(FACT-1592) A key/value pair for Interface Speed/Duplex #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
For the record, I'd like to see this functionality. It looks useful for day-to-day work. |
joshcooper
reviewed
Feb 28, 2023
|
|
joshcooper
reviewed
May 9, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
2 times, most recently
from
f58b1ef
to
199809c
Compare
joshcooper
reviewed
May 9, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
199809c
to
86622c0
Compare
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
86622c0
to
533ff31
Compare
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
533ff31
to
4b0aa25
Compare
joshcooper
reviewed
Sep 12, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
4b0aa25
to
d35a77e
Compare
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
629e071
to
66ef22a
Compare
joshcooper
reviewed
Sep 13, 2023
joshcooper
reviewed
Sep 13, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
66ef22a
to
b86e723
Compare
|
Updated |
|
I disabled the |
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
b86e723
to
9a4557b
Compare
|
rebased |
joshcooper
reviewed
Sep 13, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
2 times, most recently
from
1115a9c
to
55adeca
Compare
joshcooper
reviewed
Sep 13, 2023
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
2 times, most recently
from
2b4350e
to
7df3bf0
Compare
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
2 times, most recently
from
4c6ec37
to
01f02e3
Compare
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
01f02e3
to
372aa59
Compare
Signed-off-by: Pat Riehecky <[email protected]>
jcpunk
force-pushed
the
FACT-1592-speed-duplex
branch
from
372aa59
to
a5267b3
Compare
|
I made a slight modification to a5267b3, added a refactor commit and opened a new PR to supersede this one. Thank you for your contribution (and patience!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll confess, I'll need help with the tests....
This partially resolves the issue for Linux systems.
Facter will have a
speedfact equal to the link speed determined by the kernel for each supported interface.Facter will have a
duplexfact equal to the duplex determined by the kernel for each supported interface.For wired networks this should report the speed/duplex even if the interface is not assigned an address.