(FACT-1385) (FACT-1364) BigNum and FixedNum fix ups on Windows #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the method `rb_num2long` was changed in Ruby 2.2. to return a long, some unit tests were failing in Ruby 2.2. on windows because they were expecting it to return a 64-bit type. Update facter to use `num2size_t` and `rb_num2ll` methods instead in order to fix this issue. This fix also relies on an update to leatherman which adds the num2size_t and rb_num2ll methods to the Ruby API.
Prior to this commit, when printing out fact values, facter only supported numbers it could identify as a fixednum or a double. This meant that anything that was a bignum would not be printed. Update the write and to_json methods so that they support bignums. This fix also relies on an update to leatherman which adds the ability to recognize bignums to the ruby API.
|
We messed up tagging Leatherman 0.5.0, so you'll need to use 0.5.1. |
|
CLA signed by all contributors. |
Update .travis.yaml and appveyor.yml to use the newest version of leatherman.
HAIL9000
force-pushed
the
issue/stable/FACT-1364_FACT-1385_integers_on_windows
branch
from
048dd55 to
7441c61
Compare
|
👍 |
|
I'm ok to merge this now so Branan can continue some other work using new Leatherman, and add tests in a follow-on PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two Facter tickets. The first is FACT-1385 which
involved updating Facter so that our tests which relied on the rb_num2long
returning a long did not fail on Windows with Ruby 2.2.
The second is FACT-1364, which involved updating the printing methods
in Facter to recognize integers larger than 64-bits and display them
properly.
Both these changes rely on the new release of Leatherman.