Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-23297 setup ssh access for windows #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaigy
Copy link
Contributor

@shaigy shaigy commented Jun 6, 2018

Setup ssh access to windows agent nodes from the task runner

@@ -56,12 +56,25 @@ def run_puppet_access_login(user:, password: '~!@#$%^*-/ aZ', lifetime: '5y')
#TODO: Implement on windows
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch :)

Setup ssh access to windows agent nodes from the task runner
@shaigy shaigy force-pushed the PE-23297-Fix-ssh-access-for-windows branch from 01fab77 to 8546b3d Compare June 7, 2018 14:28
@shaigy
Copy link
Contributor Author

shaigy commented Jun 7, 2018

Updated

@MikaelSmith
Copy link
Contributor

This seems reasonable.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

@nmburgan
Copy link
Contributor

nmburgan commented Jun 8, 2021

@shaigy Do we still need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants