Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimizing 3d detector debug window on Windows OS #2047

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

papr
Copy link
Contributor

@papr papr commented Nov 11, 2020

Issue reported on Discord.

Traceback provided via email

2020-11-09 10:01:22,385 - eye0 - [ERROR] launchables.eye: Process Eye0 crashed with trace:
Traceback (most recent call last):
  File "launchables\eye.py", line 731, in eye
  File "site-packages\glfw\__init__.py", line 1772, in poll_events
  File "site-packages\glfw\__init__.py", line 632, in errcheck
  File "site-packages\glfw\__init__.py", line 54, in _reraise
  File "site-packages\glfw\__init__.py", line 611, in callback_wrapper
  File "shared_modules\pupil_detector_plugins\visualizer_3d.py", line 290, in on_resize
  File "shared_modules\gl_utils\trackball.py", line 57, in set_window_size
ZeroDivisionError: float division by zero
  • Cause: On Windows OS, the window size becomes zero in both dimensions when then window is minimized
  • Fix: Assume a minimum height/width of 1. Precedence.

Copy link
Contributor

@romanroibu romanroibu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ reproduced the issue on master
  • ✅ confirmed the issue is fixed by this PR

@papr papr changed the base branch from master to develop November 11, 2020 17:01
@papr papr merged commit 4982ccc into develop Nov 11, 2020
@papr papr deleted the fix-debug-window-minimize-windows branch November 11, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants