-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass eye camera focal_length to 3D detector #1995
Conversation
Often plugins need to know whether the UI exists or now. It does not exist in __init__ or when the menu was removed before. This property makes this information available for all plugins.
Introduces new RecordingInfo version v2.3
@papr @romanroibu I added some tests to the description, maybe you can coordinate with regards to testing and having a look at the code changes. |
@papr should I add a comment that only the focal lengths of the eye camera intrinsics were actually measured and the rest is currently just default values (for principal point) and identities (for distortion coordinates)? |
Yes, please do so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
performed the tests (except for the last step with mobile recording) and everything seems to work file 👍🏻
I'll fix the merge conflicts... |
This PR uses the eye camera intrinsics (specifically focal_length) to get a more accurate 3D eyeball position estimate.
Depends on pupil-detectors v1.1.1, upgrade with
Summary
g_pool.capture.intrinsics.focal_length
(cannot be changed at runtime)Tests
Run Capture and open the 3D detector debug window while wearing a headset. The eyeball-center z coordinate should be relatively stable (+/-5mm). Switch the resolution of the eye camera. The debug window reopens with a reset model. After stabilizing, the eyeball-center z coordinate should settle down to the same value as with the other resolution (+/-5mm).
Make a recording, the recording should contain
eye0.intrinsics
andeye1.intrinsics
files.Open the recording in player and check that the post-hoc pupil detection works fine.
Open an older recording in player and check that the post-hoc pupil detection works fine. The recording should contain
eye0.intrinsics
andeye1.intrinsics
files afterwards.Open a fresh pupil mobile recording in player and check that the post-hoc pupil detection works fine. The recording should contain
eye0.intrinsics
andeye1.intrinsics
files afterwards.