Remove plural form heuristics from XmlDeserializer and use generic test names #3
+292
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes experimental plural form matching logic from
XmlDeserializer.HandleListDerivative()while preserving the core nested element fix. Refactors test classes from domain-specific names (Category/Categories) to generic names (Item/Items).Changes
XmlDeserializer.cs
name + "s",lowercase + "s") from container lookupElements()vsDescendants()logic that fixes nested element inclusion bugIsValidXmlElementName()helper for generic type name validationRemoveNamespace()to filter null attributesTest classes (NestedElementTestClasses.cs)
Category→ItemCategoryContainer→ItemContainerCategoryWithAssociations→ItemWithGroupCategoryAssociations→ItemGroupCategoriesResponse→ItemsResponse<item>,<items>,<subitems>instead of category terminologyExample
Before (with plural logic):
After (property name only):
Tests validate proper handling of nested structures without relying on pluralization heuristics:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.