ci-mgmt onboarding by blampe · Pull Request #446 · pulumi/pulumi-pulumiservice

blampe · 2024-11-18T22:46:11Z

This onboards the provider to new workflows consistent with pulumi/ci-mgmt#1140. This doesn't change anything with regard to the release process, but it does bring the provider up-to-speed with current best practices and it will make it easier to automatically manage with ci-mgmt in the future.

Notable changes:

Java publishing
Embedding versioning (respectSchemaVersion)
Sharded tests
Goreleaser replaced by pulumi/pulumi-package-publisher

github-actions · 2024-11-18T22:56:57Z

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

This reverts commit d536e4a.

IaroslavTitov

Left some questions, mostly curiosity

IaroslavTitov · 2024-12-05T23:45:18Z

+install_plugins: .pulumi/bin/pulumi
+
+bin/linux-amd64/$(PROVIDER): TARGET := linux-amd64
+bin/linux-arm64/$(PROVIDER): TARGET := linux-arm64


These 2 lines are exactly the same - is there supposed to be a different configuration here? Same with darwin, and lines below as well

They are for ARM and x86 targets. Eventually with pulumi/ci-mgmt#1131 you shouldn't need to see or care about this.

Oooh, I'm just blind, didn't spot the 2 letter difference

IaroslavTitov · 2024-12-05T23:48:26Z

@@ -1,4 +1,5 @@
 //go:build dotnet || all
+// +build dotnet all


What do these comments do? I didn't even realize they were there

These +build tags are equivalent to the go:build ones and are just added for compatibility I guess.

IaroslavTitov · 2024-12-05T23:52:57Z

    <PackageProjectUrl>https://pulumi.com</PackageProjectUrl>
    <RepositoryUrl>https://github.com/pulumi/pulumi-pulumiservice</RepositoryUrl>
    <PackageIcon>logo.png</PackageIcon>
+    <Version>1.0.0-alpha.0+dev</Version>


Will this version be correct in an actual release? This commited version will only be used for local testing? I see it in other SDK, so guessing it's fine, just want to make sure

During release PROVIDER_VERSION will be set. We just need a placeholder for when that's not set.

IaroslavTitov · 2024-12-05T23:56:42Z

@@ -0,0 +1,20 @@
+name: Upload SDK asset


Are all the .yml action/workflow files standardized? Any of them written specifically for PSP (beyond changing PROVIDER: pulumiservice)? I see that some are auto-generated, but a lot are not, so just curious as to what's generic and what's specialized

Nothing manually, these are all generated.

If you do need some manual workflows, those files should be prefixed with pulumiservice- so they don't get overwritten.

IaroslavTitov · 2024-12-06T00:06:05Z

+        total:
+        - 6
+        index:
+        - 0


This sharding of tests is awesome! Is it possible to NOT run them in parallel within a shard though? As far as I understood, that's why the logs are jumbled up like in example below. I guess it would be losing speed, but debugging any failures would be easier.

=== NAME TestGoTeamsExample command.go:121: Command completed without output command.go:46: **** Invoke '/opt/hostedtoolcache/pulumi/3.142.1-alpha.xbe2d2a5/x64/pulumi stack import --file stack.json' in '/home/runner/go/src/stackName-1733429656837535781-118258' === NAME TestYamlSchedulesExample command.go:118: Wrote output to /tmp/test-stack-22792-510911093/command-output/pulumi-stack-rm.20241205-201450.c9ae5.log

We're actually in the process of removing gotestfmt because it doesn't handle parallel output correctly pulumi/ci-mgmt#1069

Instead of worrying about this CI output we're trying to move in a direction where it's significantly easier to reproduce CI failures locally.

codecov · 2024-12-06T16:16:15Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

pulumi-bot · 2024-12-09T20:30:55Z

This PR has been shipped in release v0.27.2.

ci-mgmt onboarding

4f481c4

blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 18, 2024

generate workflows

f66eabb

blampe force-pushed the blampe/ci-mgmt branch from a0bbe5c to f66eabb Compare November 18, 2024 22:47

lint errors

c95b043

blampe added 2 commits November 18, 2024 15:11

consolidate go.mod

6ecc848

provider targets

86cbe48

blampe force-pushed the blampe/ci-mgmt branch from bb88e07 to 86cbe48 Compare November 18, 2024 23:12

fix sdk

ca60add

blampe force-pushed the blampe/ci-mgmt branch from 23f3cca to 1d3b1a6 Compare November 18, 2024 23:26

provider version

43a2c7c

blampe force-pushed the blampe/ci-mgmt branch from 1d3b1a6 to 43a2c7c Compare November 18, 2024 23:27

blampe added 17 commits November 18, 2024 15:49

fix build tags

6903d22

debug

e4ef234

debug

3b344ba

disble auto acquisition

578e3cb

install provider binary for examples

532a111

sdk version embedding

1336d2f

fix java

13fdcbd

fix random provider

0cc43da

respect schema version?

3a6d582

ugh

8f9abb9

use embedded version

bd627a8

ignore ambient plugins during codegen

ce09a54

java ignores

39968dc

use pyproject

5bae1d9

rm build.gradle

dc01d40

no version for java

28014a5

no really

9c8d0c7

blampe added 5 commits November 19, 2024 13:34

install

5a64d2b

scope PULUMI_IGNORE_AMBIENT_PLUGINS

a2a6f74

lint

ff8b239

missing env vars

4c5f562

fix env vars

75fdb4b

blampe force-pushed the blampe/ci-mgmt branch from c94a2b9 to 75fdb4b Compare November 19, 2024 23:58

This was referenced Nov 21, 2024

Publish Java Package to Maven Central #329

Closed

Add to ci-mgmt #338

Closed

mjeffryes assigned blampe Nov 22, 2024

blampe added 3 commits December 5, 2024 10:37

revert sharding for now

d536e4a

remove PULUMI_API

56e70ec

Revert "revert sharding for now"

aa33917

This reverts commit d536e4a.

blampe requested a review from IaroslavTitov December 5, 2024 20:43

IaroslavTitov approved these changes Dec 6, 2024

View reviewed changes

blampe merged commit f3a1b8a into main Dec 6, 2024

blampe deleted the blampe/ci-mgmt branch December 6, 2024 16:16

Conversation

blampe commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 18, 2024

Does the PR have any schema changes?

Uh oh!

IaroslavTitov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Dec 6, 2024

Welcome to Codecov 🎉

Uh oh!

pulumi-bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blampe commented Nov 18, 2024 •

edited

Loading

IaroslavTitov left a comment •

edited

Loading