Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly convert port number to a string so Node doesn't colorize the output. #319

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

jesperseverinsen
Copy link
Contributor

@jesperseverinsen jesperseverinsen commented Dec 6, 2023

Fix to issue with Pulumi logging port as number, resulting in colorization of output.

Following practise of files Dynamic Provider and Provider

@jesperseverinsen
Copy link
Contributor Author

@justinvp Hey there, sorry for the ping, but wanna give a heads up on this

@jesperseverinsen
Copy link
Contributor Author

@Zaid-Ajaj can you have a look at this?

@justinvp
Copy link
Member

justinvp commented Jan 7, 2024

/run-acceptance-tests

Copy link

github-actions bot commented Jan 7, 2024

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some commits to adjust things slightly.

@justinvp justinvp merged commit 363d0d3 into pulumi:master Jan 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants