Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Config/getProject/getStack/isDryRun in policy packs #169

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Dec 5, 2019

Depends on pulumi/pulumi#3612. The tests will fail until we have a new release of the CLI and @pulumi/pulumi.

@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 5, 2019
@justinvp justinvp requested review from chrsmith and ekrengel December 5, 2019 21:01
Copy link
Contributor

@chrsmith chrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits here and there, but this overall looks like a good addition.

tests/integration/basic_data/policy-pack/PulumiPolicy.yaml Outdated Show resolved Hide resolved
tests/integration/basic_data/policy-pack/index.ts Outdated Show resolved Hide resolved
tests/integration/basic_data/policy-pack/index.ts Outdated Show resolved Hide resolved
tests/integration/basic_data/program/index.ts Outdated Show resolved Hide resolved
tests/integration/basic_data/program/resource.ts Outdated Show resolved Hide resolved
@justinvp justinvp merged commit bcc39bf into master Jan 2, 2020
@pulumi-bot pulumi-bot deleted the justin/data branch January 2, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants