Refactor controller to use Automation API

[metral]

Proposed changes

Refactor controller to use Automation API

Related issues (optional)

Closes #85

[lblackstone]

Looking good overall! Since it looks like the automation API doesn't support a few existing features yet, do we want to hold off on this, or is it better to move ahead with the refactor?

[EvanBoyle]

I believe the secrets provider work is the last big TODO for automation API and we should have feature parity after that. I'm not opposed to holding off until that lands.

[metral]

do we want to hold off on this, or is it better to move ahead with the refactor?

I'm not opposed to holding off until that lands.

Thanks for the review! Holding off SGTM 👍

[lblackstone]

🎉 Looks awesome!

[EvanBoyle]

This looks great! Awesome to see so much red! 🚀

One thing I noticed was that there is a small regression in functionality. Previously pulumi up and company were being run through the runCmd func which has it's own io handling to pipe stdout to logs that can be followed by kubectl and such:

pulumi-kubernetes-operator/pkg/controller/stack/stack_controller.go

Lines 500 to 530 in 6a4943a

	stdoutR, stdoutW := io.Pipe()
	stderrR, stderrW := io.Pipe()
	cmd.Stdout = stdoutW
	cmd.Stderr = stderrW
	// Start the command asynchronously.
	err := cmd.Start()
	if err != nil {
	return "", "", err
	}
	// Kick off some goroutines to stream the output asynchronously. Since Pulumi can take
	// a while to run, this helps to debug issues that might be ongoing before a command completes.
	var stdout bytes.Buffer
	var stderr bytes.Buffer
	go func() {
	outs := bufio.NewScanner(stdoutR)
	for outs.Scan() {
	text := outs.Text()
	sess.logger.Info(title, "Path", cmd.Path, "Args", cmd.Args, "Stdout", text)
	stdout.WriteString(text + "\n")
	}
	}()
	go func() {
	errs := bufio.NewScanner(stderrR)
	for errs.Scan() {
	text := errs.Text()
	sess.logger.Info(title, "Path", cmd.Path, "Args", cmd.Args, "Text", text)
	stderr.WriteString(text + "\n")
	}
	}()

Given that updates are run through automation API, those logs won't flow anymore. A solution here is to wire up ProgressStreams from this PR pulumi/pulumi#5367 for up/refresh/destroy/preview with the io.Writer from the logging interface (not sure if that's a logging interface or if it just goes to stdout). Not blocking, but something to consider.

[metral]

Opened #87 to track the use of ProgressStreams for logs.