support for ReconcileRequest annotation #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 50.47% 50.70% +0.23%
==========================================
Files 30 30
Lines 4115 4171 +56
==========================================
+ Hits 2077 2115 +38
- Misses 1854 1872 +18
Partials 184 184 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
Nov 8, 2024
EronWright
commented
Nov 8, 2024
| @@ -865,7 +920,7 @@ func (r *StackReconciler) markStackFailed(sess *stackReconcilerSession, instance | |||
| if last != nil { | |||
| instance.Status.LastUpdate.LastSuccessfulCommit = last.LastSuccessfulCommit | |||
| } | |||
| if last != nil && last.Generation == current.Generation { | |||
| if last != nil && last.Generation == current.Generation && last.ReconcileRequest == current.ReconcileRequest { | |||
There was a problem hiding this comment.
Rationale: reset the backoff when a resync is requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements support for requesting a re-sync of the stack (i.e.
pulumi up) using thepulumi.com/reconciliation-requestannotation.The logic of checking the prerequisites was moved to be after the check for "is synced", since the prereq check has the side-effect of touching the parent stack, and that shouldn't happen unless the child is needing a sync.
Related issues (optional)
Closes #672
Closes #398