fixes to push docker image #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
added
the
impact/no-changelog-required
blampe
reviewed
Sep 25, 2024
blampe
reviewed
Sep 25, 2024
| @@ -45,7 +45,7 @@ func TestE2E(t *testing.T) { | |||
| b := make([]byte, 12) | |||
| _, _ = rand.Read(b) //nolint:staticcheck // Don't need crypto here. | |||
| tag := hex.EncodeToString(b) | |||
| projectimage := "pulumi/pulumi-kubernetes-operator-v2:" + tag | |||
| projectimage := "pulumi/pulumi-kubernetes-operator:" + tag | |||
There was a problem hiding this comment.
I worry about folks currently using pulumi/pulumi-kubernetes-operator:latest. This has the potential to break people, or at least require some manual migration steps -- assuming we eventually publish v2 to latest.
There was a problem hiding this comment.
I sympathize. My plan is to NOT apply a suffix, but also NOT push to latest. Then, in coming weeks, we will see whether usage of latest tapers off.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #688 +/- ##
=======================================
Coverage 49.11% 49.11%
=======================================
Files 26 26
Lines 2877 2877
=======================================
Hits 1413 1413
Misses 1287 1287
Partials 177 177 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)