-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Consolidate go.mod #686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #686 +/- ##
=======================================
Coverage 49.11% 49.11%
=======================================
Files 26 26
Lines 2877 2877
=======================================
Hits 1413 1413
Misses 1287 1287
Partials 177 177 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with removing the tests/
folder because it seems obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw that the Dockerfile was moved, which is fine but please update the Makefile and goreleaser file accordingly.
There's targets docker-build
docker-buildx
and bundle
to consider. I suppose you could move some stuff down to the root makefile. The 'bundle' images are, I suppose, most obviously tied to the operator and bundle
target seems to belong in operator makefile.
Good call @EronWright I fixed pointed goreleader and |
@@ -74,7 +74,7 @@ dockers: | |||
goarch: amd64 | |||
|
|||
# Path to the Dockerfile (from the project root). | |||
dockerfile: operator/Dockerfile | |||
dockerfile: Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that goreleaser doesn't provide the necessary context or VERSION parameter for our Dockerfile, so this is probably not working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I also realized we're skipping the docker step during the dry run? Oh well not a big deal since we'll be getting rid of this anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should remove the dockers
section of the goreleaser if it isn't expected to work.
Co-authored-by: Eron Wright <[email protected]>
{operator,agent}/go.mod
under a rootgo.mod
./test
-- these were still referring to v1 code and can be revived in a followup if we want to keep any of them.Makefile targets are unchanged except for a small rename docker-rootless → docker-nonroot.
Fixes #687.