Stack controller tests #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
added
the
impact/no-changelog-required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #671 +/- ##
==========================================
+ Coverage 26.17% 33.24% +7.07%
==========================================
Files 25 25
Lines 3947 3949 +2
==========================================
+ Hits 1033 1313 +280
+ Misses 2772 2474 -298
- Partials 142 162 +20 ☔ View full report in Codecov by Sentry. |
EronWright
force-pushed
the
stack-tests
branch
from
ed79d2c to
2078ab4
Compare
EronWright
commented
Sep 20, 2024
EronWright
commented
Sep 20, 2024
blampe
approved these changes
Sep 20, 2024
| @@ -64,7 +69,7 @@ var _ = BeforeSuite(func() { | |||
| // Note that you must have the required binaries setup under the bin directory to perform | |||
| // the tests directly. When we run make test it will be setup and used automatically. | |||
| BinaryAssetsDirectory: filepath.Join("..", "..", "..", "bin", "k8s", | |||
| fmt.Sprintf("1.29.0-%s-%s", runtime.GOOS, runtime.GOARCH)), | |||
| fmt.Sprintf("1.28.3-%s-%s", runtime.GOOS, runtime.GOARCH)), | |||
There was a problem hiding this comment.
The suite for the workspace controller uses 1.28.3 and I think the CI script knows that. I guess I used a slightly different scaffolder for the stack controller.
EronWright
commented
Sep 20, 2024
Comment on lines
521
to
537
| // annotate the out of date stack so that it'll be queued. The value is arbitrary; this | ||
| // value gives a bit of context which might be helpful when troubleshooting. | ||
| v := fmt.Sprintf("update prerequisite of %s at %s", instance.Name, time.Now().Format(time.RFC3339)) | ||
| prereqStack1 := prereqStack.DeepCopy() | ||
| a := prereqStack1.GetAnnotations() | ||
| if a == nil { | ||
| a = map[string]string{} | ||
| } | ||
| a[shared.ReconcileRequestAnnotation] = v | ||
| prereqStack1.SetAnnotations(a) | ||
| log.Info("requesting requeue of prerequisite", "name", prereqStack1.Name, "cause", requireErr.Error()) | ||
| if err := r.Client.Patch(ctx, prereqStack1, client.MergeFrom(&prereqStack)); err != nil { | ||
| // A conflict here may mean the prerequisite has been changed, or it's just been | ||
| // run. In any case, requeueing this object means we'll see the new state of the | ||
| // world next time around. | ||
| return reconcile.Result{}, fmt.Errorf("annotating prerequisite to force requeue: %w", err) | ||
| } |
There was a problem hiding this comment.
I'm reverting this change and doing a follow-up: #672
EronWright
commented
Sep 20, 2024
EronWright
commented
Sep 20, 2024
EronWright
commented
Sep 20, 2024
EronWright
commented
Sep 20, 2024
rquitales
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements a test suite for the new stack controller.
Closes #654
Related issues (optional)