Update controller-gen, fix make test
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
commented
May 10, 2024
| controller-gen crd paths="$apis_dir/..." crd:crdVersions=v1 output:crd:dir="$deploy_dir" | ||
|
|
||
| # Manually overwrite until issue is resolved in controller-tools: | ||
| # https://git.io/JJsjs |
There was a problem hiding this comment.
This issue was resolved and the workaround no longer appears necessary.
blampe
commented
May 10, 2024
| @@ -48,7 +48,7 @@ push-image: | |||
|
|
|||
| test: codegen download-test-deps | |||
| KUBEBUILDER_ASSETS="$(shell setup-envtest --use-env use -p path)" \ | |||
| ginkgo -nodes=${TEST_NODES} --randomize-all ./test/... | |||
| go run github.com/onsi/ginkgo/v2/ginkgo -nodes=${TEST_NODES} --randomize-all -v ./... | |||
There was a problem hiding this comment.
We weren't running unit tests under pkg...
rquitales
approved these changes
May 10, 2024
There was a problem hiding this comment.
Looks like I made a tracking issue for improving tests awhile back that captured the fact we're not running unit tests: #447. Also weird that make test doesn't work locally for you as well. I can't seem to repro that myself, but it doesn't hurt to update controller-gen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testwas panicking locally with controller-gen v0.9.2.This updates controller-gen to v0.15, regenerates CRDs, and fixes a few other things to get
make testrunnable locally.