Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pulumi SDK version and base image to 3.55.0 #412

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

squaremo
Copy link
Contributor

@squaremo squaremo commented Feb 14, 2023

3.54.0 contains the fix for cloning Azure DevOps repos:

https://github.com/pulumi/pulumi/pull/12001

The base image change is not strictly needed, but keeping it current with the SDK version seems like a good idea. (The automated bumps don't do this).

This should fix #286.

EDIT: NB the bump was actually to v3.55.0, see #412 (comment).

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for build failures

@squaremo
Copy link
Contributor Author

squaremo commented Feb 15, 2023

This is failing because the base image pulumi/pulumi:3.54.0 is missing. I was going for the least recently released version that contains the Azure DevOps fix, the rationale being: it's been in the field the longest. But I'll change it to the most recently released.
(This makes a lie out of the branch name, but a mostly harmless one)

3.55.0 contains the fix for cloning Azure DevOps repos:

    pulumi/pulumi#12001

The base image change is not strictly needed, but keeping it current
with the SDK version seems like a good idea. (The automated bumps don't
do this).

Signed-off-by: Michael Bridgen <[email protected]>
@squaremo squaremo force-pushed the bump-sdk-base-image-3.54.0 branch from 8f789ab to 2b68392 Compare February 15, 2023 10:35
@squaremo squaremo changed the title Bump Pulumi SDK version and base image to 3.54.0 Bump Pulumi SDK version and base image to 3.55.0 Feb 15, 2023
@squaremo squaremo merged commit c3e1c89 into master Feb 15, 2023
@squaremo squaremo deleted the bump-sdk-base-image-3.54.0 branch February 15, 2023 10:47
squaremo added a commit that referenced this pull request Mar 9, 2023
 - recategorise recently merged PRs into v1.11.1
 - fix date for v1.11.0
 - fix description and link given for #412

Signed-off-by: Michael Bridgen <[email protected]>
squaremo added a commit that referenced this pull request Mar 9, 2023
- recategorise recently merged PRs into v1.11.1
 - fix date for v1.11.0
 - fix description and link given for #412

Signed-off-by: Michael Bridgen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clone Azure DevOps repo
2 participants