Parallelise and randomize tests #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the tests take O(1m) to run, and the more specs added the longer the runtime. Parallelising the tests will help defer the day we need to increase the overall timeout. Randomising helps keep the tests independent, by surfacing things that work by coincidence. Enabling either of these requires the use of the Ginkgo command line -- it's not possible to enable them programmatically. So: reinstate the use of `ginkgo` for running tests. Signed-off-by: Michael Bridgen <[email protected]>
squaremo
force-pushed
the
parallelise-tests
branch
from
72a81fa to
d90997e
Compare
squaremo
added
the
impact/no-changelog-required
lukehoban
approved these changes
Oct 4, 2022
| @@ -45,7 +45,8 @@ push-image: | |||
| docker push $(IMAGE_NAME):$(VERSION) | |||
|
|
|||
| test: codegen download-test-deps | |||
| KUBEBUILDER_ASSETS="$(shell setup-envtest --use-env use -p path)" go test -v ./test/... | |||
| KUBEBUILDER_ASSETS="$(shell setup-envtest --use-env use -p path)" \ | |||
| ginkgo -nodes=4 --randomizeAllSpecs ./test/... | |||
There was a problem hiding this comment.
Is this now also a dev machine dependency? Should it be added to README/CONTRIBUTING?
There was a problem hiding this comment.
ginkgo is mentioned as a prerequisite in docs/build.md already (I didn't remove it when I changed the Makefile the last time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the tests take O(1m) to run, and the more specs added the longer the runtime. Parallelising the tests will help defer the day we need to increase the overall timeout.
Randomising helps keep the tests independent, by surfacing things that work by coincidence.
Enabling either of these requires the use of the Ginkgo command line -- it's not possible to enable them programmatically. So: reinstate the use of
ginkgofor running tests.(Empirically, I found that using
ginkgo -pwould result in timeouts waiting for the control plane to start.-nodes=4seems like a reasonable compromise.)