Promote Stack CR spec to v1 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveklak
commented
Oct 11, 2021
| ) | ||
|
|
||
| // StackSpec defines the desired state of Pulumi Stack being managed by this operator. | ||
| type StackSpec struct { |
There was a problem hiding this comment.
This follows an older version of the migration guide for upgrading api spec, see operator-framework/operator-sdk@0481703#diff-b99ea84873816658e12d1bdd8431f78a61cf882b6961467738c9503ab3db553b
The current tooling doesn't allow us the ability to install webhooks to perform translation of CRDs so culling deprecated fields is not possible right now. We will have to do that as part of #212 in time for v2 release. By keeping the core api spec the same, we maintain backward compatibility for existing stack specs.
lblackstone
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #215
Changes have been split up into commits to aid reviewing.
Related issues (optional)
#215