Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CR docs #205

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Generate CR docs #205

merged 3 commits into from
Oct 4, 2021

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Oct 2, 2021

Proposed changes

Uses https://github.com/fybrik/crdoc to generate rudimentary docs for Stack CR.

Related issues (optional)

Fixes #173

Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now as an incremental improvement over "no docs". Eventually, I think we'll want to integrate something more closely with ours docs site, and the inline HTML may cause problems there.

// - AWS: "s3://<my-pulumi-state-bucket>"
// - Azure: "azblob://<my-pulumi-state-bucket>"
// - GCP: "gs://<my-pulumi-state-bucket>"
// (optional) Backend is an optional backend URL to use for all Pulumi operations.<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to include HTML snippets in Go comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah consider this to just be a stop-gap for now... I am still investigating a better alternative for the documentation generation. In this instance, the rendering is busted without the embedded line breaks.

@viveklak viveklak merged commit 2d91d48 into master Oct 4, 2021
@viveklak viveklak deleted the vl/CRDocs branch October 4, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output struct fields as documentation
2 participants