Bump controller runtime to support graceful upgrades #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveklak
changed the title
lblackstone
approved these changes
Aug 18, 2021
go.mod
Outdated
Comment on lines
29
to
31
| // This replaced version includes controller-runtime predicate utilities necessary for v1.0.0 that are still in master. | ||
| // Remove this and require the next minor/patch version of controller-runtime (>v0.6.1) when released. | ||
| replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.6.1-0.20200724132623-e50c7b819263 | ||
| replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.6.2 |
There was a problem hiding this comment.
It looks like we might be able to remove this block?
viveklak
force-pushed
the
vl/ControllerRuntime
branch
from
62bde0e to
506b546
Compare
viveklak
force-pushed
the
vl/ControllerRuntime
branch
from
506b546 to
bb5b6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
This picks up kubernetes-sigs/controller-runtime@21a81bc
We need to follow-up with an upgrade of controller runtime with a more recent version which we will track in #149