Upgrade pulumi-terraform-bridge to v3.127.0#1540
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c635df7ff9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -25,7 +25,7 @@ import ( | |||
| // | |||
| // func main() { | |||
| // pulumi.Run(func(ctx *pulumi.Context) error { | |||
| // _, err := cloudflare.LookupAccount(ctx, &cloudflare.LookupAccountArgs{ | |||
| // _, err := cloudflare.GetAccount(ctx, &cloudflare.LookupAccountArgs{ | |||
There was a problem hiding this comment.
This sample now invokes cloudflare.GetAccount with LookupAccountArgs, but GetAccount is the resource read helper (GetAccount(ctx, name, id, state, ...)) while the data-source invoke function in this file is still LookupAccount(ctx, args, ...). As written, the example does not compile when copied, and the same pattern appears across the regenerated get*.go docs.
Useful? React with 👍 / 👎.
| { | ||
| // Create a DNS record | ||
| var www = new Cloudflare.DnsRecord("www"); | ||
| var www = new Cloudflare.Index.DnsRecord("www"); |
There was a problem hiding this comment.
The quickstart now references Cloudflare.Index.DnsRecord, but this SDK defines resources under Pulumi.Cloudflare and does not provide a Pulumi.Cloudflare.Index namespace. Users following this snippet will hit a compile-time namespace/type error, so the generated C# docs are currently broken.
Useful? React with 👍 / 👎.
Does the PR have any schema changes?Found 1 breaking change: Resources
Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been shipped in release v6.15.0. |
1 similar comment
|
This PR has been shipped in release v6.15.0. |
2 participants
This PR was generated via
$ upgrade-provider pulumi/pulumi-cloudflare --repo-path . --kind bridge --target-bridge-version v3.127.0 --upstream-provider-org cloudflare.Fixes applied to unblock upgrade
provider/resources.go: moved the manualresourcesWithMistypedIDComputeIDoverrides to run beforeprov.MustComputeTokens(...)so bridgev3.127.0can see Cloudflare's explicit non-stringidhandling during token fixups and apply the matching schema behavior automatically.Related upstream issue
fixes #1528