Add oidcTokenFilePath to Provider InputProperties#4559
Merged
Zaid-Ajaj merged 1 commit intoMar 2, 2026
Conversation
Contributor
|
Hi there 👋 Thank you for submitting a pull request. Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack. Maintainers: Please review changes then run tests by adding the comment: |
Contributor
Author
|
Hey @Zaid-Ajaj! I forgot to include the |
The oidcTokenFilePath config option was already defined in the config variables section but was missing from the Provider InputProperties, preventing it from being used as an explicit provider constructor argument in the SDKs.
MaayanLaav
force-pushed
the
oidc-token-file-provider-param
branch
from
1246537 to
201ebe9
Compare
Zaid-Ajaj
approved these changes
Mar 2, 2026
Contributor
|
@MaayanLaav We did need to sdk-generate these inputs so that the languages have access to it. I will do that myself before I release this |
Zaid-Ajaj
added a commit
that referenced
this pull request
Mar 2, 2026
) PR #4559 added `oidcTokenFilePath` to `schema.go` Provider InputProperties but didn't regenerate the committed `schema.json` or language SDKs, so the property wasn't usable as a Provider constructor argument. - **schema.json**: Added `oidcTokenFilePath` to `provider.inputProperties` - **SDK regeneration**: Ran `make generate` equivalent for all languages (Node.js, Python, .NET, Go, Java) Remaining diff beyond the provider property is standard codegen output (doc examples, formatting). ```typescript const provider = new azure_native.Provider("p", { oidcTokenFilePath: "/path/to/oidc-token", }); ``` ```python provider = azure_native.Provider("p", oidc_token_file_path="/path/to/oidc-token", ) ``` <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/pulumi/pulumi-azure-native/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
Contributor
|
This PR has been shipped in release v3.15.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
oidcTokenFilePathconfig option was already defined in the config variables section but was missing from the Provider InputProperties, preventing it from being used as an explicit provider constructor argument in the SDKs.It's useful for running different stacks in the same environment.