Add /upgrade-azure-api slash command#4405
Merged
Merged
Conversation
This slash command provides a comprehensive workflow for upgrading Azure API versions in the pulumi-azure-native provider, based on the process used to add CosmosDB hybrid search support. Key features: - Interactive guidance through the complete upgrade workflow - Fast iteration using DEBUG_CODEGEN_NAMESPACES - Explicit warnings about common mistakes (e.g., git add -u vs -A) - Troubleshooting section referencing existing playbooks - PR template for consistent documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4405 +/- ##
==========================================
+ Coverage 59.37% 59.46% +0.08%
==========================================
Files 91 91
Lines 11450 11531 +81
==========================================
+ Hits 6799 6857 +58
- Misses 4015 4025 +10
- Partials 636 649 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
You might consider an option to upgrade an API without bumping the submodule -- that tends to bring in unrelated changes that break things. Also, only commit changes in sdk. I was testing this with some untracked files that ended up getting committed. |
Updates based on completing PR #4404 (CosmosDB hybrid search) and reviewer feedback: - Add dedicated "Submodule Management" section explaining trade-offs - Default to NOT updating submodule (avoids pulling unrelated changes) - Add Step 9: make generate_docs (was missing, caused incomplete PRs) - Add Step 10: optional provider build verification - Use explicit git add paths instead of -A (prevents committing untracked files) - Add "Stale PR / Rebasing" troubleshooting guidance Addresses feedback from @blampe on PR #4405. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This PR has been shipped in release v3.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
/upgrade-azure-apislash command that provides comprehensive guidance for upgrading Azure API versions in the pulumi-azure-native provider.Motivation
This command codifies the workflow used to successfully add CosmosDB hybrid search support (PR #4404), making it easier for maintainers to perform future API version upgrades consistently.
Features
DEBUG_CODEGEN_NAMESPACESfor quick testing cyclesgit add -uinstead ofgit add -AWorkflow Steps
versions/v3-spec.yamlgit add -A)Testing
Related Work
customizing-resources.md,Resolving-api-merge-conflicts.md🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com