Skip to content

Fix WebAppAuthSettingsV2 deletion #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EronWright merged 4 commits into from
Oct 24, 2025
Merged

Fix WebAppAuthSettingsV2 deletion #4373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bee224f
Fix WebAppAuthSettingsV2 deletion by adding to default resources state
EronWright Oct 23, 2025
2377cbf
Remove unnecessary platform.enabled workaround from appservice test
EronWright Oct 23, 2025
240d13c
Regenerate SDKs
EronWright Oct 23, 2025
451bbcc
Set GITHUB_TOKEN at workflow level to address rate limiting
EronWright Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ env:
PULUMI_API: https://api.pulumi-staging.io
# Feature toggle that's read in provider.go enableAzcoreBackend()
PULUMI_ENABLE_AZCORE_BACKEND: ${{ inputs.use_azcore }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# AZURE_CLI_FOLDER is the content of a ~/.azure/ folder, zipped and base64-encoded, for CLI auth.
# If/when the contained refresh token expires, someone with access to our subscription needs to
# `az login` on their own computer and repeat the steps below.
Expand Down
3 changes: 0 additions & 3 deletions examples/appservice/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ new web.WebAppConnectionStrings("conns", {
new web.WebAppAuthSettingsV2("auth", {
resourceGroupName: resourceGroup.name,
name: app.name,
platform: {
enabled: false,
},
httpSettings: {
requireHttps: true,
},
Expand Down
10 changes: 10 additions & 0 deletions provider/pkg/openapi/defaults/defaultResourcesState.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,16 @@ var defaultResourcesStateRaw = map[string]map[string]interface{}{
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettings": {
"enabled": false,
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2": {
"platform": map[string]interface{}{
"enabled": false,
},
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2": {
"platform": map[string]interface{}{
"enabled": false,
},
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/logs": {
"applicationLogs": map[string]string{},
},
Expand Down
18 changes: 18 additions & 0 deletions reports/allResourceVersionsByResource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30589,6 +30589,24 @@
"2021-01-15",
"2021-02-01"
],
"WebAppAuthSettingsV2WithoutSecrets": [
"2021-03-01",
"2022-03-01",
"2022-09-01",
"2023-01-01",
"2023-12-01",
"2024-04-01",
"2024-11-01"
],
"WebAppAuthSettingsV2WithoutSecretsSlot": [
"2021-03-01",
"2022-03-01",
"2022-09-01",
"2023-01-01",
"2023-12-01",
"2024-04-01",
"2024-11-01"
],
"WebAppAzureStorageAccounts": [
"2018-02-01",
"2018-11-01",
Expand Down
84 changes: 84 additions & 0 deletions reports/allResourcesByVersion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157022,6 +157022,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2021-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2021-03-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2021-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2021-03-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2021-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2021-03-01/WebApps.json",
Expand Down Expand Up @@ -157648,6 +157660,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2022-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-03-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2022-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-03-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2022-03-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-03-01/WebApps.json",
Expand Down Expand Up @@ -158304,6 +158328,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2022-09-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-09-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2022-09-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-09-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2022-09-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2022-09-01/WebApps.json",
Expand Down Expand Up @@ -158972,6 +159008,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2023-01-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-01-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2023-01-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-01-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2023-01-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-01-01/WebApps.json",
Expand Down Expand Up @@ -159640,6 +159688,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2023-12-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-12-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2023-12-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-12-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2023-12-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2023-12-01/WebApps.json",
Expand Down Expand Up @@ -160314,6 +160374,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2024-04-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-04-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2024-04-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-04-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2024-04-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-04-01/WebApps.json",
Expand Down Expand Up @@ -160994,6 +161066,18 @@
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettings",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecrets": {
"ApiVersion": "2024-11-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-11-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAuthSettingsV2WithoutSecretsSlot": {
"ApiVersion": "2024-11-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-11-01/WebApps.json",
"ResourceUri": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/sites/{name}/slots/{slot}/config/authsettingsV2",
"RpNamespace": "Microsoft.Web"
},
"WebAppAzureStorageAccounts": {
"ApiVersion": "2024-11-01",
"SpecFilePath": "specification/web/resource-manager/Microsoft.Web/AppService/stable/2024-11-01/WebApps.json",
Expand Down
Loading
Loading