Skip to content

Fix missing password in tests #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blampe merged 4 commits into from
Sep 30, 2025
Merged

Fix missing password in tests #4321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
997dd96
Fix missing password in tests
blampe Sep 29, 2025
f11831b
temporarily force long tests on pr
blampe Sep 30, 2025
2a56bb2
fix lint
blampe Sep 30, 2025
16f95f5
update azurelint
blampe Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
self-hosted-runner:
labels:
- pulumi-ubuntu-8core

paths:
".github/workflows/build-test.yml":
ignore:
- 'property "esc-secrets" is not defined in object type {}'
2 changes: 1 addition & 1 deletion .github/workflows/actionlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ jobs:
uses: actions/checkout@v4

- name: Lint actions
uses: reviewdog/action-actionlint@v1.57.0
uses: reviewdog/action-actionlint@v1.67.0
with:
actionlint_flags: "-config-file .actionlint.yml"
4 changes: 4 additions & 0 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@
env:
# specifying this id will cause the OIDC test(s) to run against this AD application
OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }}
ARM_CLIENT_SECRET: ${{ steps.esc-secrets.outputs.ARM_CLIENT_SECRET }}
ARM_CLIENT_CERTIFICATE_PASSWORD_FOR_TEST: ${{ steps.esc-secrets.outputs.ARM_CLIENT_CERTIFICATE_PASSWORD }}
run: |
set -euo pipefail
cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
Expand Down Expand Up @@ -296,6 +298,8 @@
env:
# specifying this id will cause the OIDC test(s) to run against this AD application
OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }}
ARM_CLIENT_SECRET: ${{ steps.esc-secrets.outputs.ARM_CLIENT_SECRET }}

Check failure on line 301 in .github/workflows/build-test.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build-test.yml#L301 

property "esc-secrets" is not defined in object type {} [expression]
Raw output 
e:.github/workflows/build-test.yml:301:34: property "esc-secrets" is not defined in object type {} [expression]
ARM_CLIENT_CERTIFICATE_PASSWORD_FOR_TEST: ${{ steps.esc-secrets.outputs.ARM_CLIENT_CERTIFICATE_PASSWORD }}

Check failure on line 302 in .github/workflows/build-test.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build-test.yml#L302 

property "esc-secrets" is not defined in object type {} [expression]
Raw output 
e:.github/workflows/build-test.yml:302:57: property "esc-secrets" is not defined in object type {} [expression]
run: |
set -euo pipefail
cd examples && \
Expand Down
Loading