Skip to content

Fix nightly SDK issues#4315

Merged
blampe merged 3 commits into
masterfrom
blampe/nightly
Sep 26, 2025
Merged

Fix nightly SDK issues#4315
blampe merged 3 commits into
masterfrom
blampe/nightly

Conversation

@blampe

@blampe blampe commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Fixes #4270.

Manual changes:

  • .github/workflows/build-test.yml: Added the jlumbroso/free-disk-space action to build_test because we started eating up all our disk.
  • provider/pkg/gen/merging.go: updated the error message to point at the playbook, because I can never remember how to handle these cases.
  • provider/pkg/gen/types.go: Added aliases for some BillingBenefits enums which were generating conflicting Go types.
  • provider/pkg/openapi/discover.go: Excluded two invalid/unprocessable specs:
    • Microsoft.Cdn/preview/2025-05-01-preview
    • Microsoft.AzureArcData/preview/2025-06-01-preview

While we have some functionality for excluding API versions as part of v3-config.yaml, those versions still end up getting processed for the purpose of generating request/response types. Ultimately it's much more straightforward to exclude the versions altogether, but it took me a while to track this down.

@github-actions

github-actions Bot commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Found 54 breaking changes:

Resources

  • "azure-native:apimanagement:WorkspaceBackend": required:
    • 🟢 "protocol" property is no longer Required
    • 🟢 "url" property is no longer Required
  • "azure-native:billingbenefits:Discount":
    • inputs:
      • 🟡 "appliedScopeType" missing
      • 🟡 "displayName" missing
      • 🟡 "entityType" missing
      • 🟡 "productCode" missing
      • 🟡 "startAt" missing
      • 🟡 "systemId" missing
    • properties:
      • 🟡 "appliedScopeType" missing output "appliedScopeType"
      • 🟡 "benefitResourceId" missing output "benefitResourceId"
      • 🟡 "billingAccountResourceId" missing output "billingAccountResourceId"
      • 🟡 "billingProfileResourceId" missing output "billingProfileResourceId"
      • 🟡 "customerResourceId" missing output "customerResourceId"
      • 🟡 "displayName" missing output "displayName"
      • 🟡 "entityType" missing output "entityType"
      • 🟡 "productCode" missing output "productCode"
      • 🟡 "provisioningState" missing output "provisioningState"
      • 🟡 "startAt" missing output "startAt"
      • 🟡 "status" missing output "status"
      • 🟡 "systemId" missing output "systemId"
  • 🟢 "azure-native:cdn:AFDOrigin": required: "hostName" property is no longer Required
  • "azure-native:cdn:Endpoint": properties:
    • 🟡 "deliveryPolicy" type changed from "#/types/azure-native:cdn:EndpointPropertiesUpdateParametersResponseDeliveryPolicy" to "#/types/azure-native:cdn:EndpointPropertiesUpdateParametersDeliveryPolicyResponse"
    • 🟡 "webApplicationFirewallPolicyLink" type changed from "#/types/azure-native:cdn:EndpointPropertiesUpdateParametersResponseWebApplicationFirewallPolicyLink" to "#/types/azure-native:cdn:EndpointPropertiesUpdateParametersWebApplicationFirewallPolicyLinkResponse"
  • 🟢 "azure-native:cdn:OriginGroup": required: "origins" property is no longer Required
  • 🟢 "azure-native:cdn:Route": required: "originGroup" property is no longer Required
  • "azure-native:cdn:Rule": required:
    • 🟢 "actions" property is no longer Required
    • 🟢 "order" property is no longer Required
  • "azure-native:containerinstance:CGProfile":
    • inputs:
      • 🟡 "registeredRevisions" missing
      • 🟡 "revision" missing
    • properties:
      • 🟡 "registeredRevisions": items type changed from "number" to "integer"
      • 🟡 "revision" type changed from "number" to "integer"
    • required inputs:
      • 🟢 "containers" input has changed to Required
      • 🟢 "osType" input has changed to Required
  • 🟡 "azure-native:redis:Redis": properties: "redisConfiguration" type changed from "#/types/azure-native:redis:RedisCommonPropertiesResponseRedisConfiguration" to "#/types/azure-native:redis:RedisCommonPropertiesRedisConfigurationResponse"

Types

  • 🟢 "azure-native:azurearcdata:FailoverClusterResponse": required: "hostIPAddresses" property has changed to Required
  • 🟢 "azure-native:azurearcdata:SqlServerAvailabilityGroupResourcePropertiesResponse": required: "vmId" property has changed to Required
  • 🟢 "azure-native:azurearcdata:SqlServerDatabaseResourcePropertiesResponse": required: "vmId" property has changed to Required
  • "azure-native:azurearcdata:SqlServerInstancePropertiesResponse": required:
    • 🟢 "dbMasterKeyExists" property has changed to Required
    • 🟢 "isDigiCertPkiCertTrustConfigured" property has changed to Required
    • 🟢 "isHadrEnabled" property has changed to Required
    • 🟢 "isMicrosoftPkiCertTrustConfigured" property has changed to Required
    • 🟢 "maxServerMemoryMB" property has changed to Required
    • 🟢 "traceFlags" property has changed to Required
    • 🟢 "vmId" property has changed to Required
  • 🟡 "azure-native:cdn:CustomerCertificateParameters": properties: "subjectAlternativeNames" missing
  • 🟢 "azure-native:cdn:CustomerCertificateParametersResponse": required: "subjectAlternativeNames" property has changed to Required
  • 🔴 "azure-native:cdn:EndpointPropertiesUpdateParametersResponseDeliveryPolicy" missing
  • 🔴 "azure-native:cdn:EndpointPropertiesUpdateParametersResponseWebApplicationFirewallPolicyLink" missing
  • 🟡 "azure-native:cdn:PolicySettings": properties: "defaultCustomBlockResponseStatusCode" type changed from "integer" to "number"
  • 🟡 "azure-native:cdn:PolicySettingsResponse": properties: "defaultCustomBlockResponseStatusCode" type changed from "integer" to "number"
  • 🟡 "azure-native:cdn:RequestSchemeMatchConditionParameters": properties: "operator" type changed from "string" to ""
  • "azure-native:redis:PrivateEndpointConnectionResponse": required:
    • 🟢 "groupIds" property has changed to Required
    • 🟢 "systemData" property has changed to Required
  • 🔴 "azure-native:redis:RedisCommonPropertiesResponseRedisConfiguration" missing

New resources:

  • azuredatatransfer.FlowProfile
  • cognitiveservices.RaiTopic
  • containerinstance.NGroup
  • containerservice.JWTAuthenticator
  • datamigration.DatabaseMigrationsSqlMi
  • datamigration.DatabaseMigrationsSqlVm
  • monitor.Issue
  • storagecache.AutoImportJob

New functions:

  • azuredatatransfer.getFlowProfile
  • cognitiveservices.getRaiTopic
  • containerinstance.getNGroup
  • containerservice.getJWTAuthenticator
  • datamigration.getDatabaseMigrationsSqlMi
  • datamigration.getDatabaseMigrationsSqlVm
  • dbforpostgresql.getPrivateDnsZoneSuffix
  • dependencymap.getMapDependencyViewForAllMachines
  • monitor.getIssue
  • monitor.listIssueAlerts
  • monitor.listIssueResources
  • network.listVirtualNetworkGatewayRadiusSecrets
  • network.listVpnServerConfigurationRadiusSecrets
  • storagecache.getAutoImportJob

@codecov

codecov Bot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.67%. Comparing base (ab2c3c1) to head (a34aba3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/types.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4315      +/-   ##
==========================================
- Coverage   59.70%   59.67%   -0.04%     
==========================================
  Files          90       90              
  Lines       14135    14135              
==========================================
- Hits         8440     8435       -5     
- Misses       5039     5043       +4     
- Partials      656      657       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EronWright EronWright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blampe blampe merged commit bc100d8 into master Sep 26, 2025
25 checks passed
@blampe blampe deleted the blampe/nightly branch September 26, 2025 22:14
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v3.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failure: nightly-sdk-generation

3 participants